Skip to content

Add ucx test #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pi314ever wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Add ucx test #711

pi314ever wants to merge 14 commits into from
+346 −105

Conversation

@pi314ever
Copy link

@pi314ever pi314ever commented Dec 12, 2025 •
edited
Loading

Adds pd nixl UCX test to CI. This is dependent on intel-staging/ucx#1

Copilot AI review requested due to automatic review settings December 12, 2025 01:15
@github-actions
Copy link

github-actions bot commented Dec 12, 2025

🚧 CI Blocked

The main CI workflow was not started for the following reason:

Your branch is behind the base branch. Please merge or rebase to get the latest changes.

Copilot AI reviewed Dec 12, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for UCX testing in the CI pipeline by introducing a new test function and making the UCX transport layer selection configurable based on the buffer device type.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
tests/unit_tests/run_accuracy_test.sh Makes UCX_TLS configurable, using gaudi-specific settings when buffer device is HPU, and restores proper git root detection
tests/full_tests/ci_gsm8k_tests.sh Adds new test function for PD disaggregate through NIXL UCX

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot mentioned this pull request Dec 12, 2025
Open
@xuechendi xuechendi self-assigned this Dec 12, 2025
@xuechendi xuechendi marked this pull request as draft December 12, 2025 15:50
@xuechendi
Copy link
Collaborator

xuechendi commented Dec 12, 2025

Since intel-staging/ucx#1 is not merged yet, convert the PR to draft to avoid repeated CI
@pi314ever , once the UCX PR merged, please convert back to ready for review and update branch to retrigger CI

@pi314ever pi314ever mentioned this pull request Dec 13, 2025
Draft
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

🚧 CI Blocked

The main CI workflow was not started for the following reason:

This is a Draft PR. Please mark it as 'Ready for Review' to trigger the CI.

@pi314ever
Add ucx test
72a6cd7 
Signed-off-by: Daniel Huang <[email protected]>
@pi314ever
Add install script
46c9b86 
Signed-off-by: Daniel Huang <[email protected]>
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

🚧 CI Blocked

The main CI workflow was not started for the following reason:

This is a Draft PR. Please mark it as 'Ready for Review' to trigger the CI.

@pi314ever pi314ever marked this pull request as ready for review January 6, 2026 00:04
@pi314ever pi314ever mentioned this pull request Jan 9, 2026
Closed
@pi314ever
Add wheels cache
5bbd8c9 
Signed-off-by: Daniel Huang <[email protected]>
@pi314ever
Fix cwd for ucx acc test
d07f62d 
Signed-off-by: Daniel Huang <[email protected]>
@pi314ever
Trigger ci
d24d372 
Signed-off-by: Daniel Huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@kzawora-intel kzawora-intel Awaiting requested review from kzawora-intel kzawora-intel is a code owner

@xuechendi xuechendi Awaiting requested review from xuechendi xuechendi is a code owner

@adobrzyn adobrzyn Awaiting requested review from adobrzyn adobrzyn is a code owner

@mgawarkiewicz-intel mgawarkiewicz-intel Awaiting requested review from mgawarkiewicz-intel mgawarkiewicz-intel is a code owner

@afierka-intel afierka-intel Awaiting requested review from afierka-intel afierka-intel is a code owner

@michalkuligowski michalkuligowski Awaiting requested review from michalkuligowski michalkuligowski is a code owner

@iboiko-habana iboiko-habana Awaiting requested review from iboiko-habana iboiko-habana is a code owner

@kamil-kaczor kamil-kaczor Awaiting requested review from kamil-kaczor kamil-kaczor is a code owner

@ksmusz ksmusz Awaiting requested review from ksmusz ksmusz is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@xuechendi xuechendi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pi314ever @xuechendi